[ 
https://issues.apache.org/jira/browse/NIFI-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060184#comment-15060184
 ] 

Mark Payne commented on NIFI-1215:
----------------------------------

Applied patch and tested locally. All appears to be good. Code review looks 
good. The only change that I would recommend is that the warning that indicates 
that data may be lost if the source processor is using a Run Duration > 0 ms 
should be displayed only if the Run Duration is actually set to something 
higher than 0 ms. I.e., if it is scheduled with a run duration of 0 ms, there 
should be no warning. Otherwise I'm a +1

> UI exposes a slider for Run Duration even for Processors that do not support 
> it
> -------------------------------------------------------------------------------
>
>                 Key: NIFI-1215
>                 URL: https://issues.apache.org/jira/browse/NIFI-1215
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core UI
>            Reporter: Mark Payne
>            Assignee: Matt Gilman
>             Fix For: 0.5.0
>
>         Attachments: 0001-NIFI-1215.patch
>
>
> If a Processor does not have a @SupportsBatching annotation, the Processor 
> cannot support the configurable Run Duration. However, the UI still exposes 
> the slider, allowing the user to configure it. Instead, the UI should show 
> the component as disable with an indicator that "This feature is not 
> supported by this Processor"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to