[
https://issues.apache.org/jira/browse/NIFI-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085855#comment-15085855
]
Aldrin Piri commented on NIFI-108:
----------------------------------
Overall, looks good. A few items of note below, none of them being blockers
exclusive of some docs to accompany the new feature. With some docs, +1
Major, We need documentation in the user guide to accompany this contribution
detailing things like needing to have both source and destination processors
stopped
Minor, FlowFileQueue, Ln 307: verifyCanList - any reason to not have this just
be canList
Minor, DropRequestDTO, Ln 75: Value for getUri. Not sure if it is a typo or
if something else is implied, but it mentions "futures requests." Are we
talking about just future requests? or about Futures?
Trivial, FlowFileDTO, Ln 96: missing ' in "flowfiles content begins"
Minor, ListingRequestDTO, Ln 70: Same comment as above with "futures"
Minor, Some of the files have had the imports shuffled. Examples include
StandardFlowFileQueue, WebClusterManager, and TestStandardFlowFileQueue
Trivial, Connection resource "uri's" should be "uris"
> DFM should be allowed to inspect/interact with FlowFiles on a Connection
> ------------------------------------------------------------------------
>
> Key: NIFI-108
> URL: https://issues.apache.org/jira/browse/NIFI-108
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework, Core UI
> Reporter: Matt Gilman
> Assignee: Matt Gilman
> Fix For: 0.5.0
>
> Attachments: NIFI-108_Purge-List_Queue_Flow.xml, nifi-108.dump
>
>
> User should be able to see the attributes, as well as download the content
> and possibly remove an item from the queue (destroy the FlowFile entirely).
> Users should also be able to upload a new object into the queue (as requested
> at an apache nifi DC/MD/VA meetup).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
