[
https://issues.apache.org/jira/browse/NIFI-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089508#comment-15089508
]
Josh Elser commented on NIFI-1367:
----------------------------------
(background: I was the one who asked the question)
An important detail also mentioned was that NiFi hasn't had any significant
issue with whether or not some contribution has sufficiently met the "bar" for
being ready to commit. Given my personal involvement in other projects, I've
seen the following happen a few times:
1. Contribution is provided for inclusion to $project
2. Contributor feels code is of sufficient quality for commit (seems to often
happen with "experimental" or WIP features)
3. Committers are split on whether or not the contribution should actually be
applied
Again, personally, I have seen these situations come across rather volatile,
often being charged with personal feelings (rather than technical facts). RTC
communities have it a bit easier because they have explicit guidelines on what
is a "passing review". CTR can be a bit trickier since any committer can push
the code forward w/o any barrier other than trust. Having some guidance that
can be regularly pointed to that satisfies what the current committership
considers sufficient can help defuse these situations before they happen (or,
maybe you'll be lucky and never run into one either!).
Common criteria:
* Has new docs
* Has new tests
* Passes checkstyle
* Passes static analysis tools (findbugs, etc)
* Passes existing tests
Happy to help out here (mostly what I've seen from personal experience) if the
collective consider this something worthwhile to pursue (I don't feel
comfortable writing it on my own without some discussion to make sure I don't
put words in the project's mouth). If it's not something that's a big deal
right now, it can also be pursued at a later time :)
> Provide some guidelines and basis for providing contributions and getting
> them incorporated
> -------------------------------------------------------------------------------------------
>
> Key: NIFI-1367
> URL: https://issues.apache.org/jira/browse/NIFI-1367
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Documentation & Website
> Reporter: Aldrin Piri
> Priority: Minor
>
> From the NiFi Meetup:
> Provide some guidance as to what the community looks for in contributions in
> terms of quality, tests, documentation and the like. The notion here is not
> to establish hard and fast rules, but rather provide pointers that can
> facilitate getting contributions incorporated into the codebase and a basis
> for determinations that may be made in a review.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
