[
https://issues.apache.org/jira/browse/NIFI-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094233#comment-15094233
]
ASF GitHub Bot commented on NIFI-1156:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49479161
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java
---
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.io.InputStreamCallback;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.jsoup.Jsoup;
+import org.jsoup.nodes.Document;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.concurrent.atomic.AtomicReference;
+
+public abstract class AbstractHTMLProcessor extends AbstractProcessor {
+
+ protected static final String ELEMENT_HTML = "HTML";
+ protected static final String ELEMENT_TEXT = "Text";
+ protected static final String ELEMENT_DATA = "Data";
+ protected static final String ELEMENT_ATTRIBUTE = "Attribute";
+
+ public static final PropertyDescriptor URL = new PropertyDescriptor
+ .Builder().name("URL")
+ .description("Base URL for the HTML page being parsed.")
+ .required(true)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor CSS_SELECTOR = new
PropertyDescriptor
+ .Builder().name("CSS Selector")
+ .description("CSS selector syntax string used to extract the
desired HTML element(s).")
+ .required(true)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .expressionLanguageSupported(true)
+ .build();
+
+ public static final PropertyDescriptor HTML_CHARSET = new
PropertyDescriptor
+ .Builder().name("HTML character encoding")
+ .description("Character encoding of the input HTML")
+ .defaultValue("UTF-8")
+ .required(true)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ public static final Relationship REL_ORIGINAL = new
Relationship.Builder()
+ .name("original")
+ .description("The original HTML input")
+ .build();
+
+ public static final Relationship REL_SUCCESS = new
Relationship.Builder()
+ .name("success")
+ .description("Successfully parsed HTML element")
+ .build();
+
+ public static final Relationship REL_FAILURE = new
Relationship.Builder()
+ .name("failure")
+ .description("Failed to parse HTML content")
--- End diff --
I am not sure that I understand the difference between 'failure' and
'invalid html' relationships. I would think that if we "fail to parse HTML
content", then it is because "The input HTML syntax is invalid" but those are
two separate relationships. Can you expand on the descriptions a bit?
> HTML Parsing Processors Bundle
> ------------------------------
>
> Key: NIFI-1156
> URL: https://issues.apache.org/jira/browse/NIFI-1156
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
> Reporter: Jeremy Dyer
> Priority: Minor
>
> NiFi provides the ability to ingest HTML but lacks the convenience to easily
> interact with that HTML once it has entered the flow. There should be a HTML
> Processing Bundle that provides mechanisms for manipulating and interacting
> with HTML data once it has entered the flow. Jsoup http://jsoup.org/ seems
> like a logical tool to use since it is mature and has a MIT license which
> would allow it to be incorporated into NiFi.
> “GetHTMLElement” should use the CSS selector-syntax
> (http://www.w3schools.com/cssref/css_selectors.asp) built into Jsoup to
> extract 0-N HTML elements from the original HTML input. This processor should
> support a delimited string of selectors allowing the user to build compound
> HTML element output. Each HTML element (or compound element result) extracted
> will create a new Flowfile where the element will be in either the Flowfile
> content or an attribute depending on the user configuration.
> “ModifyHTMLElement” should provide the ability to modify the original input
> HTML and overwrite any existing element values. The HTML element that will be
> modified can be selected by using the CSS selector-syntax
> “PutHTMLElement” should provide the ability to put a new HTML element
> anywhere in the original input HTML using CSS selector-syntax to indicate the
> position that the new HTML element should be placed.
> There seems to be a potential for adding more processors but this seems like
> a good start. Since there is a dependency on Jsoup and a potential for more
> processors to come I think it makes sense to add this logic as its own nar
> bundle but I could be wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
