[
https://issues.apache.org/jira/browse/NIFI-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098983#comment-15098983
]
Thad Guidry edited comment on NIFI-1368 at 1/14/16 10:26 PM:
-------------------------------------------------------------
[~aldrin] Much progress today...
Found out that some of the test themselves are not well aligned for being
ThreadSafe with Surefire and with the use of <parallel>all</parallel>
In order to help with this, I researched and found that perhaps we can mark
those particular test classes that cause problems with the parallel option as
-@NotThreadSafe, as described here:
http://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html
, in particular the line that says "This way the parallel execution of tests
classes annotated with @NotThreadSafe are forked in single thread instance
(don't mean forked JVM process)."
I have already annotated several classes so far as I go through the whole build
to try to get to success with these config options for Surefire:
<parallel>all</parallel>
<useUnlimitedThreads>true</useUnlimitedThreads>
and the parallel test executions are now working much faster on Windows,
although I am not at a complete successful build yet...but as I add the
annotation to those particular classes that exhibit the FAILURE during the
build on Windows, they then are able to pass with SUCCESS.
Thoughts or Concerns on this annotation ?
was (Author: thadguidry):
[~aldrin] Much progress today...
Found out that some of the test themselves are not well aligned for being
ThreadSafe with Surefire and with the use of <parallel>all</parallel>
In order to help with this, I researched and found that perhaps we can mark
those particular test classes that cause problems with the parallel option as
-@NotThreadSafe, as described here:
http://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html
, in particular the line that says "This way the parallel execution of tests
classes annotated with @NotThreadSafe are forked in single thread instance
(don't mean forked JVM process)."
I have already annotated several classes so far as I go through the whole build
to try to get to success with these config options for Surefire:
<parallel>all</parallel>
<useUnlimitedThreads>true</useUnlimitedThreads>
and the parallel test executions are now working much faster on Windows,
although I am not at a complete successful build yet...
Thoughts or Concerns on this annotation ?
> Test Failures on Windows 7
> --------------------------
>
> Key: NIFI-1368
> URL: https://issues.apache.org/jira/browse/NIFI-1368
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 0.4.1
> Reporter: Aldrin Piri
> Attachments: AppData-Local-Temp.zip, hs_err_pid11228.log,
> nifi-debug-build-on-windows.txt, nifi-standard-processors.zip
>
>
> Environment
> {code}
> C:\dev\code\nifi>mvn -version
> Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
> 2015-03-13T16:10:27-04:00)
> Maven home: C:\dev\apache-maven-3.3.1\bin\..
> Java version: 1.7.0_79, vendor: Oracle Corporation
> Java home: C:\dev\lang\java\jdk1.7.0_79\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> {code}
> Errors included are:
> {code}
> Running org.apache.nifi.controller.scheduling.TestStandardProcessScheduler
> Tests run: 9, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 53.155 sec
> <<< FAILURE! - in
> org.apache.nifi.controller.scheduling.TestStandardProcessScheduler
> testDisableControllerServiceWithProcessorTryingToStartUsingIt(org.apache.nifi.controller.scheduling.TestStandardProcessScheduler)
> Time elapsed: 3.024 sec <<< FAILURE!
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.nifi.controller.scheduling.TestStandardProcessScheduler.testDisableControllerServiceWithProcessorTryingToStartUsingIt(TestStandardProcessScheduler.java:139)
> testReportingTaskDoesntKeepRunningAfterStop(org.apache.nifi.controller.scheduling.TestStandardProcessScheduler)
> Time elapsed: 3.75 sec <<< FAILURE!
> java.lang.AssertionError: After unscheduling Reporting Task, task ran an
> additional 3 times
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> org.apache.nifi.controller.scheduling.TestStandardProcessScheduler.testReportingTaskDoesntKeepRunningAfterStop(TestStandardProcessScheduler.java:113)
> {code}
> As well as the attached file found by a user trying to build with a similar
> environment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
