[
https://issues.apache.org/jira/browse/NIFI-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109347#comment-15109347
]
ASF GitHub Bot commented on NIFI-1156:
--------------------------------------
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/124#issuecomment-173351611
Jeremy,
I've been reviewing this and I made a handful of minor changes:
* Copied licensing information to the nar - it was already present in
nifi-assembly. Just had to create a LICENSE file for the nar itself.
* Updated version from 0.4.0-SNAPSHOT to 0.4.2-SNAPSHOT
* Improved error handling (if we hit any RuntimeException, such as the
Content Repository is out of disk space, it was routing to the "invalid html"
relationship)
* Updated some code to match the nifi style a bit more (adding 'final'
keywords, using longer max line width (200 chars is the max we use with nifi))
I did not change the logic of any of the Processors, though. All very solid
stuff.
Excited to see this getting into NiFi! Thanks for all of the work that
you've put into this!
> HTML Parsing Processors Bundle
> ------------------------------
>
> Key: NIFI-1156
> URL: https://issues.apache.org/jira/browse/NIFI-1156
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
> Reporter: Jeremy Dyer
> Priority: Minor
>
> NiFi provides the ability to ingest HTML but lacks the convenience to easily
> interact with that HTML once it has entered the flow. There should be a HTML
> Processing Bundle that provides mechanisms for manipulating and interacting
> with HTML data once it has entered the flow. Jsoup http://jsoup.org/ seems
> like a logical tool to use since it is mature and has a MIT license which
> would allow it to be incorporated into NiFi.
> “GetHTMLElement” should use the CSS selector-syntax
> (http://www.w3schools.com/cssref/css_selectors.asp) built into Jsoup to
> extract 0-N HTML elements from the original HTML input. This processor should
> support a delimited string of selectors allowing the user to build compound
> HTML element output. Each HTML element (or compound element result) extracted
> will create a new Flowfile where the element will be in either the Flowfile
> content or an attribute depending on the user configuration.
> “ModifyHTMLElement” should provide the ability to modify the original input
> HTML and overwrite any existing element values. The HTML element that will be
> modified can be selected by using the CSS selector-syntax
> “PutHTMLElement” should provide the ability to put a new HTML element
> anywhere in the original input HTML using CSS selector-syntax to indicate the
> position that the new HTML element should be placed.
> There seems to be a potential for adding more processors but this seems like
> a good start. Since there is a dependency on Jsoup and a potential for more
> processors to come I think it makes sense to add this logic as its own nar
> bundle but I could be wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
