[
https://issues.apache.org/jira/browse/NIFI-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109791#comment-15109791
]
Aldrin Piri commented on NIFI-108:
----------------------------------
Overall it looks good.
Build, contrib, tests all good:
https://travis-ci.org/apiri/incubator-nifi/builds/103721211
Some minor comments on the code. It was a bit hard to review in its current
state given the branching after initial incorporation, so I created a branch,
re-ordered the commits to get all of 108 together and squashed for review ease,
this and the associated comments are available at:
https://github.com/apiri/incubator-nifi/commit/65ff8217a4623e387726bebbe907c55a1e4318da.
Only a few minor comments. The biggest issue in the code is that of the
incorrect XmlRootElement for FlowFileEntity.
In terms of operational testing, I have done so against a standalone instance
as well as a small cluster running on my local machine. All seemed to work
well and handle exceptional cases in terms of nodes dropping out and the like
in a reasonable manner.
Overall, +1 to incorporate.
> DFM should be allowed to inspect/interact with FlowFiles on a Connection
> ------------------------------------------------------------------------
>
> Key: NIFI-108
> URL: https://issues.apache.org/jira/browse/NIFI-108
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework, Core UI
> Reporter: Matt Gilman
> Assignee: Matt Gilman
> Fix For: 0.5.0
>
> Attachments: NIFI-108_Purge-List_Queue_Flow.xml, nifi-108.dump
>
>
> User should be able to see the attributes, as well as download the content
> for flowfiles in the top of the active queue.
> Additional tickets have been created and linked for searching, removing, and
> uploading flowfiles in a given queue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
