[
https://issues.apache.org/jira/browse/NIFI-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111299#comment-15111299
]
ASF GitHub Bot commented on NIFI-1273:
--------------------------------------
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/179#issuecomment-173707708
Spent some time reviewing the patch. Overall, I think the code looks good.
Additional nit-picky item outside of my previous comment.
- I could see possibly wanting to extract the RELP utility classes into a
separate artifact. Maybe we wait to shuffle this around until we have a case
for it. Maybe introduce a RELP NAR if we ever get to that point.
When running ListenRELP, there were times (especially right after stopping
and starting the Processor) that new messages were not picked up for some time.
At some point later, a backlog of messages flooded in. It's not clear what
triggered it and the backlog appeared to produce some duplicate messages.
@trkurc did you want to check this out before we proceed with merging?
> Add support for RELP in ListenSyslog
> ------------------------------------
>
> Key: NIFI-1273
> URL: https://issues.apache.org/jira/browse/NIFI-1273
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Tony Kurc
> Assignee: Bryan Bende
> Priority: Minor
> Fix For: 0.5.0
>
>
> Add support for listening for syslog events using The Reliable Event Logging
> Protocol (RELP) [1]
> http://www.rsyslog.com/doc/relp.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
