[ 
https://issues.apache.org/jira/browse/NIFI-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111490#comment-15111490
 ] 

Aldrin Piri commented on NIFI-1416:
-----------------------------------

[~markap14]

Code looks good overall for the specified feature.

Build checked out:  https://travis-ci.org/apiri/incubator-nifi/builds/103952848

I additionally added a unit test while reviewing to verify the specified 
functionality and would like to fold in upon merge.  This is available at 
https://github.com/apiri/incubator-nifi/commit/7f817a9d6f47a5a20dbf9fc08f57c3465ce0891b

One thing I was uncertain of is the handling of the path when it is relative 
(as in my test case).  The property describes that this should be fully 
qualified and am wondering if situations such as the one my test case should be 
disallowed.  Thoughts?


> FetchSFTP sets filename attribute to whatever the "Remote File" property was, 
> even if it has directory names in it
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-1416
>                 URL: https://issues.apache.org/jira/browse/NIFI-1416
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Minor
>             Fix For: 0.5.0
>
>         Attachments: 
> 0001-NIFI-1416-If-FetchSFTP-s-Remote-File-has-a-directory.patch
>
>
> If the "Remote File" property of FetchSFTP is set to "myDir/myFile.txt", the 
> filename attribute that is set on the FlowFile is "myDir/myFile.txt" but 
> should be "myFile.txt".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to