[ 
https://issues.apache.org/jira/browse/NIFI-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113434#comment-15113434
 ] 

Aldrin Piri commented on NIFI-1426:
-----------------------------------

Build and contrib was all good.

Code looks good.

One item of note is that in general I like the capture of the backspace as well 
to avoid the accidental backwards navigate.  I tested this in a variety of 
places and then also verified text entries worked as anticipated.

In terms of consistency, and please let me know if you think this is beyond 
scope of this issue, would be to provide a universal capture throughout the 
app.  This can typically happen when editing a field and maybe misclick on the 
periphery of the fields on a processor for example or any of the static type 
regions throughout the app (such as missing the search on provenance or other 
similar filterable tables).

Overall, +1 to the specific scope of this, it certainly addresses some issues 
that I have certainly run into when configuring out of habit.  Seems like the 
universal capture of the backspace might also make sense, but if not, let me 
know and I can enter an issue for that.

> Allow backspace to delete selected components on the canvas
> -----------------------------------------------------------
>
>                 Key: NIFI-1426
>                 URL: https://issues.apache.org/jira/browse/NIFI-1426
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI
>            Reporter: Matt Gilman
>            Assignee: Matt Gilman
>            Priority: Minor
>             Fix For: 0.5.0
>
>         Attachments: 0001-NIFI-1426.patch
>
>
> Requiring the delete hot-key may be too restrictive when using the NiFi UI 
> especially on a laptop which lacks a physical delete button. Folks often hit 
> backspace which defaults to navigating to the previous page. This is 
> unexpected has the desired action was to remove the selected components. 
> Capturing backspace and delete may offer a more intuitive behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to