[
https://issues.apache.org/jira/browse/NIFI-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120022#comment-15120022
]
Bryan Bende commented on NIFI-1382:
-----------------------------------
Overall this looks good, patch applies and passes contrib-check, and the
processors works as designed. Some quick feedback...
* Since we are converting the byte[] to a String when placing in an attribute,
we may want to provide a Charset property which defaults to UTF-8 so that the
user can control how the bytes are decoded into a String
* For the Max Length property, I realize now that this is the length of the
string, but at first I was wondering if we should use a DATA_SIZE validator and
include the units so its 256 KB, and use this length to determine how many
bytes to use when constructing the String, just a thought since the Put
processor also has a max cache size based off bytes
* I'm on the fence about this one, but we have several other processors
(EvaluateJsonPath, EvaluateXPath, etc) where we have a Destination property
with values of "flowfile-content" and "flowfile-attribute", debating if should
use that approach here for consistency? I realize it means we need Destination
plus another property to specify the attribute name, so I could go other way on
this one.
* We may want to put a note in the description that the processor will always
read the entire cached value into memory before placing it in the destination,
just so users understand the implications of retrieving large objects
* I think that transferring a flow file already produces the appropriate
provenance events so we may not need the calls to provenance report for route
events
> Create GetDistributedMapCache Processor
> ---------------------------------------
>
> Key: NIFI-1382
> URL: https://issues.apache.org/jira/browse/NIFI-1382
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
> Fix For: 0.5.0
>
> Attachments:
> 0001-NIFI-1382-Created-GetDistributeMapCache-processor.patch
>
>
> Currently there is a PutDistributedMapCache processor but no way to get that
> information back out. There needs to be analogous processor, a
> GetDistributedMapCache processor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
