[ 
https://issues.apache.org/jira/browse/NIFI-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122986#comment-15122986
 ] 

ASF GitHub Bot commented on NIFI-1337:
--------------------------------------

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/188#discussion_r51227063
  
    --- Diff: 
nifi-nar-bundles/nifi-riemann-bundle/nifi-riemann-reporting-task/src/main/java/org/apache/nifi/reporting/riemann/metrics/MetricsService.java
 ---
    @@ -0,0 +1,388 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.reporting.riemann.metrics;
    +
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.concurrent.TimeUnit;
    +
    +import org.apache.nifi.controller.status.ProcessGroupStatus;
    +import org.apache.nifi.controller.status.ProcessorStatus;
    +import org.apache.nifi.reporting.Bulletin;
    +import org.apache.nifi.reporting.riemann.attributes.AttributeNames;
    +
    +import com.aphyr.riemann.Proto;
    +import com.google.common.base.Joiner;
    +import com.google.common.collect.Lists;
    +import com.google.common.collect.Maps;
    +import com.yammer.metrics.core.VirtualMachineMetrics;
    +
    +public class MetricsService {
    +    public final static Joiner SEP = Joiner.on('.');
    +    private final String servicePrefix;
    +    private final Collection<String> serviceTags;
    +    private final String hostName;
    +    private Map<String, String> additionalAttributes = Maps.newHashMap();
    --- End diff --
    
    should be final and ideally populated by the constructor


> Add Riemann Reporting Task
> --------------------------
>
>                 Key: NIFI-1337
>                 URL: https://issues.apache.org/jira/browse/NIFI-1337
>             Project: Apache NiFi
>          Issue Type: New Feature
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>         Attachments: example-graph.png, riemann-reporting-configuration.png
>
>
> It would be beneficial for NiFi to report health information to 
> [Riemann|http://riemann.io] for monitoring purposes. I plan on implementing 
> this, and will use this JIRA to track the progress. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to