[ 
https://issues.apache.org/jira/browse/NIFI-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131236#comment-15131236
 ] 

ASF GitHub Bot commented on NIFI-1460:
--------------------------------------

Github user taftster commented on the pull request:

    https://github.com/apache/nifi/pull/202#issuecomment-179495566
  
    1) StringBuilder should probably be preferred to StringBuffer in this case. 
 Though it probably won't matter for performance, the intention is that this is 
the unsychronized (thread safe) usage.
    
    2)  I'm opting for readability over speed.  What's wrong with something 
like:
    
    ```
    private static String createFakeUUID() {
        return new StringBuilder()
            .append("00000000-0000-0000-")
            .append(String.format("%016x", id)
            .insert(23, '-')
            .toString();
    }
    ```


> Test Performance improvement. Test Timeout Mitigation.
> ------------------------------------------------------
>
>                 Key: NIFI-1460
>                 URL: https://issues.apache.org/jira/browse/NIFI-1460
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework, Tools and Build
>    Affects Versions: 0.4.1
>         Environment: linux, unix with true random number generator.
>            Reporter: Puspendu Banerjee
>            Assignee: Tony Kurc
>            Priority: Minor
>              Labels: performance
>             Fix For: 0.6.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Existing test case 
> nifi-framework-core/src/test/java/org/apache/nifi/controller/TestStandardFlowFileQueue.java
>  uses a huge number of call to UUID.randomUUID() which is very slow in linux 
> , unix environment if there is not much activity [ like mouse move etc.] .In 
> addition to that UUID.randomUUID() depends on /dev/(u)random to get a random 
> number, such system call costs IO and /dev/random is bandwidth/rate limited  
> which again slows down overall performance.
> Workaround is rngd daemon(ref: http://linux.die.net/man/8/rngd)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to