[ 
https://issues.apache.org/jira/browse/NIFI-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150512#comment-15150512
 ] 

ASF GitHub Bot commented on NIFI-1464:
--------------------------------------

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/210#discussion_r53164352
  
    --- Diff: 
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
 ---
    @@ -71,6 +71,7 @@
         public static final String ADMINISTRATIVE_YIELD_DURATION = 
"nifi.administrative.yield.duration";
         public static final String PERSISTENT_STATE_DIRECTORY = 
"nifi.persistent.state.directory";
         public static final String BORED_YIELD_DURATION = 
"nifi.bored.yield.duration";
    +    public static final String PROCESSOR_START_TIMEOUT = 
"nifi.processor.start.timeout";
    --- End diff --
    
    I don't think we need to add default since it's handled during retrieval 
(basically if property is null or doesn't exist). 
    I'll change to string based representation of time although I am still 
struggling with the whole concept and if indeed it is more user friendly. 


> Refactor lifecycle code for Processors and other components
> -----------------------------------------------------------
>
>                 Key: NIFI-1464
>                 URL: https://issues.apache.org/jira/browse/NIFI-1464
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>             Fix For: 0.6.0
>
>
> Similar lifecycle handling improvements that went in as part of the NIFI-1164 
> for ControllerServices, could/should be applied to other  components (e..g, 
> Processors).
> The improvements may also help to address NIFI-78 (may be without killing the 
> thread).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to