[ 
https://issues.apache.org/jira/browse/NIFI-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150691#comment-15150691
 ] 

ASF GitHub Bot commented on NIFI-1521:
--------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/232#discussion_r53186223
  
    --- Diff: 
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java
 ---
    @@ -84,6 +89,72 @@
                 .allowableValues("0.9.1")
                 .defaultValue("0.9.1")
                 .build();
    +    public static final PropertyDescriptor USE_SSL_PROTOCOL = new 
PropertyDescriptor.Builder()
    +            .name("Use SSL protocol")
    +            .description("Indicates whether or not SSL protocol should be 
used")
    +            .allowableValues("true", "false")
    +            .defaultValue("false")
    +            .required(true)
    +            .build();
    +    public static final PropertyDescriptor VALIDATE_CERTIFICATES = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    I am not sure why we would allow certificates _not_ be validated on a 
secure connection. I recommend removing this option, and I strongly oppose to 
the default value being `false` if it is allowed to remain. 


> Allow SSL with AMQP processors
> ------------------------------
>
>                 Key: NIFI-1521
>                 URL: https://issues.apache.org/jira/browse/NIFI-1521
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 0.5.0
>            Reporter: Pierre Villard
>            Priority: Trivial
>              Labels: beginner
>             Fix For: 0.6.0
>
>
> AMQP processor shall allow the creation of connections using SSL protocol 
> (not necessarily with presenting and validating certificates)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to