Repository: nifi Updated Branches: refs/heads/master 9576f4160 -> 4c5263220
NIFI-1542: Update how PutS3Object handles a 403 AccessDenied response to a S3 ListMultipartUploads request. * Change log message from error to warning and added note about S3 permissions. * Advance the ageoff check time by the check interval as if the request succeeded to prevent re-checking on every upload when permission does not exist. Reviewed by Tony Kurc ([email protected]) (with minor amendments for whitespace and error message consistency). This closes #240 Project: http://git-wip-us.apache.org/repos/asf/nifi/repo Commit: http://git-wip-us.apache.org/repos/asf/nifi/commit/4c526322 Tree: http://git-wip-us.apache.org/repos/asf/nifi/tree/4c526322 Diff: http://git-wip-us.apache.org/repos/asf/nifi/diff/4c526322 Branch: refs/heads/master Commit: 4c5263220c5b45ca82a2d5119311f4a481d9bbba Parents: 9576f41 Author: Joe Skora <[email protected]> Authored: Sun Feb 21 16:05:12 2016 -0500 Committer: Tony Kurc <[email protected]> Committed: Sun Feb 21 18:11:23 2016 -0500 ---------------------------------------------------------------------- .../apache/nifi/processors/aws/s3/PutS3Object.java | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/nifi/blob/4c526322/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java ---------------------------------------------------------------------- diff --git a/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java b/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java index b0ccbc0..87f00b6 100644 --- a/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java +++ b/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java @@ -39,6 +39,7 @@ import java.util.concurrent.atomic.AtomicLong; import java.util.concurrent.locks.Lock; import java.util.concurrent.locks.ReentrantLock; +import com.amazonaws.services.s3.model.AmazonS3Exception; import org.apache.nifi.annotation.behavior.DynamicProperty; import org.apache.nifi.annotation.behavior.InputRequirement; import org.apache.nifi.annotation.behavior.InputRequirement.Requirement; @@ -695,8 +696,19 @@ public class PutS3Object extends AbstractS3Processor { ageoffLocalState(ageCutoff); lastS3AgeOff.set(System.currentTimeMillis()); } catch(AmazonClientException e) { - getLogger().error("Error checking S3 Multipart Upload list for {}: {}", - new Object[]{bucket, e.getMessage()}); + if (e instanceof AmazonS3Exception + && ((AmazonS3Exception)e).getStatusCode() == 403 + && ((AmazonS3Exception) e).getErrorCode().equals("AccessDenied")) { + getLogger().warn("AccessDenied checking S3 Multipart Upload list for {}: {} " + + "** The configured user does not have the s3:ListBucketMultipartUploads permission " + + "for this bucket, S3 ageoff cannot occur without this permission. Next ageoff check " + + "time is being advanced by interval to prevent checking on every upload **", + new Object[]{bucket, e.getMessage()}); + lastS3AgeOff.set(System.currentTimeMillis()); + } else { + getLogger().error("Error checking S3 Multipart Upload list for {}: {}", + new Object[]{bucket, e.getMessage()}); + } } finally { s3BucketLock.unlock(); }
