[
https://issues.apache.org/jira/browse/NIFI-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157458#comment-15157458
]
ASF GitHub Bot commented on NIFI-786:
-------------------------------------
GitHub user jvwing opened a pull request:
https://github.com/apache/nifi/pull/244
NIFI-786 AWS credential refactoring and enhancements
Changes to AWS credential handling:
* Refactoring the creation of AWS Credentials into a factory class for use
by AWSCredentialsProviderControllerService (included) and future shared use by
processors or other components.
* Centralized the PropertyDescriptors used for AWS Credential configuration
to standardize behavior and improve documentation.
* Improved self-documentation by making Default Credentials an explicit and
visible option, while preserving the behavior of using it implicity if no other
credential type is configured.
* In this commit, the explicit Use Default Credential option defaults to
"false", to maintain backward compatibility upgrading to this implementation.
* Credential enhancements
* New credential option - Named Profile
* New credential option - Anonymous
* Added External ID as an optional parameter for Assume Role
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jvwing/nifi NIFI-786-refactor-aws-credentials
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/244.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #244
----
commit 164ebcd9c89a28ae6c1b40fb009044bc04de3195
Author: James Wing <[email protected]>
Date: 2016-02-22T18:14:47Z
NIFI-786 AWS credential refactoring and enhancements
----
> Add other supporting options for configuring credentials for AWS processors
> ---------------------------------------------------------------------------
>
> Key: NIFI-786
> URL: https://issues.apache.org/jira/browse/NIFI-786
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Michael Kobit
> Priority: Minor
>
> I was looking at https://issues.apache.org/jira/browse/NIFI-770 and looked at
> how the AWS processors credentials are currently configured. As a NFM you
> have a few options with the properties right now:
> 1) set basic, static credentials
> 2) set a credentials properties filepath
> 3) set neither, use anonymous credentials
> I think it would be better if each AWS could rely on a ControllerService that
> returns `AWSCredentialsProvider` (instead of `AWSCredentials`) that gives
> all of the possible implementations that could be used, rather than relying
> on a static credentials. *Provider implementations can be refreshed and can
> also other more complicated implementations, but already have built in
> support for the Static and Properties file that are provided by NiFi today.
> My thinking is that the controller service would be something like
> public interface AwsCredentialsProviderService extends ControllerService {
> AWSCredentialsProvider getCredentialsProvider();
> }
> and you could have `StaticAwsCredentialsProviderService`,
> `PropertiesFileAwsCredentialsProviderService`, and
> `AnonymousAwsCredentialsProviderService` to provide the functionality that is
> supported right now. Additional credential providers could be added later, as
> there a bunch more AWS provided versions that I think could fit in well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
