[ 
https://issues.apache.org/jira/browse/NIFI-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157938#comment-15157938
 ] 

Michael Moser edited comment on NIFI-1522 at 2/22/16 11:27 PM:
---------------------------------------------------------------

An auto-completed time unit sounds good to me.

For properties, I have always liked including a time unit in the property 
itself.  Such as:

nifi.flowcontroller.graceful.shutdown.seconds
nifi.ui.autorefresh.milliseconds
nifi.provenance.repository.max.storage.minutes

But I realize that to change our property names we sacrifice backward 
compatibility, which makes requiring a time unit for new properties (to match 
the pattern used by existing properties) more compelling.


was (Author: mosermw):
An auto-completed time unit when the user doesn't enter one sounds good to me.

For properties, I have always liked including a time unit in the property 
itself.  Such as:

nifi.flowcontroller.graceful.shutdown.seconds
nifi.ui.autorefresh.milliseconds
nifi.provenance.repository.max.storage.minutes

But I realize that to change our property names we sacrifice backward 
compatibility, which makes requiring a time unit for new properties (to match 
the pattern used by existing properties) more compelling.

> Period and Unit time expressions should default to milliseconds
> ---------------------------------------------------------------
>
>                 Key: NIFI-1522
>                 URL: https://issues.apache.org/jira/browse/NIFI-1522
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joseph Witt
>            Assignee: Oleg Zhurakousky
>             Fix For: 0.6.0
>
>
> Discussion on Github about our current support for period and unit 
> expressions for time 
> https://github.com/apache/nifi/pull/210#discussion_r53167209
> We should support that if a unit of time is not specified that the period is 
> assumed to be in milliseconds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to