[
https://issues.apache.org/jira/browse/NIFI-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167205#comment-15167205
]
ASF GitHub Bot commented on NIFI-1513:
--------------------------------------
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/221#discussion_r54095802
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/bin/Bin.java
---
@@ -121,8 +125,9 @@ public boolean offer(final FlowFile flowFile, final
ProcessSession session) {
final String countValue =
flowFile.getAttribute(fileCountAttribute);
final Integer count = toInteger(countValue);
if (count != null) {
- this.maximumEntries = Math.min(count, this.maximumEntries);
- this.minimumEntries = this.maximumEntries;
+ int currentMaxEntries = this.maximumEntries;
+ this.maximumEntries = Math.min(count, currentMaxEntries);
+ this.minimumEntries = currentMaxEntries;
--- End diff --
Not sure why it was necessary (other then style), but overall PR looks good.
+1
> Fix high impact coverity issues
> -------------------------------
>
> Key: NIFI-1513
> URL: https://issues.apache.org/jira/browse/NIFI-1513
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 0.5.0
> Reporter: Tony Kurc
> Assignee: Tony Kurc
> Priority: Minor
>
> Coverity Scan discovered a few issues, this is a ticket to track progress on
> mitigating them
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
