[
https://issues.apache.org/jira/browse/NIFI-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169212#comment-15169212
]
ASF GitHub Bot commented on NIFI-1464:
--------------------------------------
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/210#issuecomment-189328683
Otherwise, I think all looks good. I definitely like the simplification of
the code. I agree that the locking is no longer necessary. It was there because
we wanted to atomically evaluate isRunning() and then update the processor, all
as a single unit, without the processor being started in the meantime. However,
this is not really a concern, since starting the processor with a separate
thread would have to be done via the web tier, which will hold a lock anyway.
Great addition! Once the DTO & FlowSerializer are addressed, and the
DISABLED state is added back in, I'll be a +1!
> Refactor lifecycle code for Processors and other components
> -----------------------------------------------------------
>
> Key: NIFI-1464
> URL: https://issues.apache.org/jira/browse/NIFI-1464
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Oleg Zhurakousky
> Assignee: Oleg Zhurakousky
> Fix For: 0.6.0
>
>
> Similar lifecycle handling improvements that went in as part of the NIFI-1164
> for ControllerServices, could/should be applied to other components (e..g,
> Processors).
> The improvements may also help to address NIFI-78 (may be without killing the
> thread).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
