[ 
https://issues.apache.org/jira/browse/NIFI-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169751#comment-15169751
 ] 

ASF GitHub Bot commented on NIFI-1568:
--------------------------------------

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/248#discussion_r54298253
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
 ---
    @@ -202,11 +213,11 @@ public void onTrigger(final ProcessContext context, 
final ProcessSession session
             final boolean addFragmentAttrs;
             switch (packagingFormat) {
                 case TAR_FORMAT:
    --- End diff --
    
    Have you considered doing some restructuring of the _onTrigger()_ method?
    Since the packaging format is based on the processor wide configuration 
property (not FlowFile) most of the logic (switch/case) could be performed once 
instead of every time _onTrigger()_ is called. That includes the new logic with 
regex pattern compile.
    Or am I missing something big here?



> Allow user to specify file filter regex when unpacking zip/tar archives 
> ------------------------------------------------------------------------
>
>                 Key: NIFI-1568
>                 URL: https://issues.apache.org/jira/browse/NIFI-1568
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>
> There are times where you may want to only extract a portion of an archive, 
> such as a specific folder, or perhaps a specific file. Similar to how the 
> {{GetFile}} processor works, we should provide a property ({{File Filter}}) 
> which  by default extracts all files. The user can modify this property to 
> extract only files they wish to process downstream. 
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to