[
https://issues.apache.org/jira/browse/NIFI-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186047#comment-15186047
]
ASF GitHub Bot commented on NIFI-1488:
--------------------------------------
Github user alopresto commented on the pull request:
https://github.com/apache/nifi/pull/253#issuecomment-194012946
@rickysaltzer Yes, I did not mean full-stack integration tests with a KDC,
just unit tests, primarily focusing on validation, especially of user input and
retrieved credentials, as that is a common security attack vector.
I do appreciate you adding simple validation tests. My only question is
regarding the extraction of the boolean check for
`UserGroupInformation.isSecurityEnabled()` in
[`HBase_1_1_2_ClientService.java`](https://github.com/rickysaltzer/nifi/blob/6dc8416b7f2cb5480a6f6ae63777ea4080263e67/nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_1_1_2_ClientService.java)
on line 137. I'm not completely familiar with the HBase components, but my
understanding is that this will now be executed statically at the class
initialization time, rather than during the `customValidate` method call. Is
this intentional?
As for @bbende , I think Groovy tests allow for easier static mocking, but
I do not consider it a priority for this PR. I think the existing unit tests
@rickysaltzer added are sufficient (although perhaps with a perfunctory check
of the error message/cause after the `runner.assertNotValid(service);` just to
ensure it's not accidentally testing something else.
> Add Kerberos Support to HBase processors
> ----------------------------------------
>
> Key: NIFI-1488
> URL: https://issues.apache.org/jira/browse/NIFI-1488
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 0.4.0, 0.4.1
> Reporter: Bryan Bende
> Assignee: Ricky Saltzer
>
> Our current HBase integration does not support communicating with a
> Kerberized HBase install. We should support this just like we do for the HDFS
> processors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
