[
https://issues.apache.org/jira/browse/NIFI-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193757#comment-15193757
]
ASF GitHub Bot commented on NIFI-1464:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/275#discussion_r56045229
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java
---
@@ -1404,9 +1389,9 @@ private void
invokeTaskAsCancelableFuture(ScheduledExecutorService taskScheduler
+ "have been written to ignore interrupts which may
result in runaway thread which could lead to more issues "
+ "eventually requiring NiFi to be restarted. This is
usually a bug in the target Processor '"
+ this.processor + "' that needs to be documented,
reported and eventually fixed.");
+ throw new RuntimeException("Timed out while executing one of
processor's lifecycle tasks (OnScheduled or OnUnscheduled).", e);
} catch (ExecutionException e){
- throw new RuntimeException(
- "Failed while executing one of processor's lifecycle
tasks (OnScheduled or OnUnscheduled).", e);
+ throw new RuntimeException("Failed while executing one of
processor's lifecycle tasks (OnScheduled or OnUnscheduled).", e);
--- End diff --
Can we pass in the name of the lifecycle event here or something? I would
avoid indicating "OnScheduled or OnUnscheduled" -- we should know when we
generate this message which one it was.
> Refactor lifecycle code for Processors and other components
> -----------------------------------------------------------
>
> Key: NIFI-1464
> URL: https://issues.apache.org/jira/browse/NIFI-1464
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Oleg Zhurakousky
> Assignee: Oleg Zhurakousky
> Fix For: 0.6.0
>
>
> Similar lifecycle handling improvements that went in as part of the NIFI-1164
> for ControllerServices, could/should be applied to other components (e..g,
> Processors).
> The improvements may also help to address NIFI-78 (may be without killing the
> thread).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
