[ 
https://issues.apache.org/jira/browse/NIFI-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198025#comment-15198025
 ] 

Joseph Percivall edited comment on NIFI-1626 at 3/16/16 8:12 PM:
-----------------------------------------------------------------

+1

Did a contrib check build and verified the code. Since ListHDFS was fixed to no 
longer create state this large there is no way to double check this change in a 
vanilla instance of NiFi. That being said, there is a unit test which directly 
checks the errors is thrown so I am Ok with merging this in.

Thanks for adding this check Mark, I will merge it in.


was (Author: jpercivall):
+1

Did a contrib check build and verified the code. Since ListHDFS was fixed to no 
longer create state this large there is no way to double check this change in a 
vanilla instance of NiFi. That being said, there is a unit test which directly 
checks the errors is thrown so I am Ok with merging this in.

Thanks for adding this simple check Mark, I will merge it in.

> ZooKeeper State Provider should block requests > 1 MB
> -----------------------------------------------------
>
>                 Key: NIFI-1626
>                 URL: https://issues.apache.org/jira/browse/NIFI-1626
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>             Fix For: 0.6.0
>
>         Attachments: 
> 0001-NIFI-1626-Throw-an-Exception-proactively-if-too-much.patch, 
> 0001-NIFI-1626-Updated-State-Management-section-of-Develo.patch
>
>
> ZooKeeper does not support setting data on a ZNode to a value greater than 1 
> MB. However, the client doesn't does not check this - it sends the data to 
> the server and lets the server reject the request. This can cause problems 
> with ZooKeeper if the requests grow extremely large. As a result, we should 
> prevent this from ever happening by throwing an Exception ourselves if 
> attempting to set state to a value > 1 MB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to