[ 
https://issues.apache.org/jira/browse/NIFI-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201845#comment-15201845
 ] 

Joseph Witt commented on NIFI-1118:
-----------------------------------

[~jskora] proposes to add SplitTextV2

I believe this does not solve the root problem and adds an avoidable migration 
hurdle.  For this reason I do not recommend this course of action.

[~markbean] In reference to fixing the defect suggests "it should be noted that 
any change which affect how this feature operates - even if it is for 
consistency sake - is changing behavior"

I believe this is inconsistent with the spirit of the a 'behavior changing' 
commit.  Changing the expected behavior of a feature is generally what is meant 
when someone refers to a behavior changing commit.  Aligning the users expected 
behavior with the actual behavior is generally considered a bug fix.  

In short I propose:
- NIFI-1649 aims to address the bug discovered. Lets fix that immediately and 
for 0.6.0 and for the reasons JoeS and MarkB have noted.
- NIFI-1118 is meant to add two new features.  It should be done after 
NIFI-1649.  If you would like the 0.6.0 release held up to include this how 
long would you like that to be?  Alternatively, could we consider doing an 
0.7.0 release to include NIFI-1118 in a short cycle after 0.6.0?  I would be 
supportive of that.

Please advise.

> Enable SplitText processor to limit line length and filter header lines
> -----------------------------------------------------------------------
>
>                 Key: NIFI-1118
>                 URL: https://issues.apache.org/jira/browse/NIFI-1118
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Mark Bean
>            Assignee: Joe Skora
>             Fix For: 0.6.0
>
>
> Include the following functionality to the SplitText processor:
> 1) Maximum size limit of the split file(s)
> A new split file will be created if the next line to be added to the current 
> split file exceeds a user-defined maximum file size
> 2) Header line marker
> User-defined character(s) can be used to identify the header line(s) of the 
> data file rather than a predetermined number of lines
> These changes are additions, not a replacement of any property or behavior. 
> In the case of header line marker, the existing property "Header Line Count" 
> must be zero for the new property and behavior to be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to