[ 
https://issues.apache.org/jira/browse/NIFI-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197425#comment-15197425
 ] 

ASF GitHub Bot commented on NIFI-1629:
--------------------------------------

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/282#discussion_r56345659
  
    --- Diff: 
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
 ---
    @@ -297,6 +320,14 @@ protected PropertyDescriptor 
getSupportedDynamicPropertyDescriptor(final String
                     .build();
         }
     
    +    @OnScheduled
    +    public void schedule(ProcessContext context) {
    +        this.deadlockTimeout = 
context.getProperty(KAFKA_TIMEOUT).asTimePeriod(TimeUnit.MILLISECONDS) * 2;
    +        if (this.executor == null || this.executor.isShutdown()) {
    +            this.executor = 
Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors());
    --- End diff --
    
    Think instead it should use newCachedThreadPool .  Behavior seems ideal for 
this case.  Need this in both procs.


> Downgrade Kafka processors back to 0.8
> --------------------------------------
>
>                 Key: NIFI-1629
>                 URL: https://issues.apache.org/jira/browse/NIFI-1629
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>             Fix For: 0.6.0
>
>
> Also, the following needs to be added to ensure that Kafka failures do not 
> affect NiFi operations
> 1) Add yield so when we don't have to ack anything or there is nothing to 
> send we don't do onTrigger()
> 2) Appropriate hooks allowing Kafka processors to still exit whenever Kafka 
> deadlocks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to