[ 
https://issues.apache.org/jira/browse/NIFI-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204179#comment-15204179
 ] 

Mark Payne commented on NIFI-1649:
----------------------------------

[~joewitt] I see the following comment in one of the unit tests you provided:

{code}
        /**
         * It appears headerline should be 'HeaderLine1\n' and is for the first
         * few splits then it is 'HeaderLine1' as you can see we lose a \n if we
         * uncomment and use the following instead it works fine.
         */
        // splits.get(3).assertContentEquals("HeaderLine1\n\n\n\n\n");
//        splits.get(4).assertContentEquals("HeaderLine1\n\n\n\n\n");
//        splits.get(5).assertContentEquals("HeaderLine1\n\n\n\n\n");
//        splits.get(6).assertContentEquals("HeaderLine1\n\n\n\n\n");
//        splits.get(7).assertContentEquals("HeaderLine1\n\n\n\n\n");
//        splits.get(8).assertContentEquals("HeaderLine1\n\n\n\n\n");
//        splits.get(9).assertContentEquals("HeaderLine1\nLastLine\n");
{code}

I'm not sure what to make of that. Above that, in the same unit test, you have 
other assertContentEquals calls, which assert a different number of new-lines. 
I believe the above ones to be correct, and they do indeed pass the unit test. 
Do you disagree?

> SplitText end of line handling is incorrect
> -------------------------------------------
>
>                 Key: NIFI-1649
>                 URL: https://issues.apache.org/jira/browse/NIFI-1649
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Joseph Witt
>            Assignee: Mark Payne
>            Priority: Critical
>             Fix For: 0.6.0
>
>         Attachments: 
> 0001-NIFI-1649-Generated-unit-tests-to-verify-behavior-de.patch, 
> 0002-NIFI-1649-Addressed-issues-with-SplitText-that-cause.patch, 
> 0003_NIFI-1649_CauseTestFail.patch, View_Content_using_wrong_content_claim.xml
>
>
> Lengthy discussion about this in NIFI-1118



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to