[
https://issues.apache.org/jira/browse/NIFI-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212096#comment-15212096
]
ASF GitHub Bot commented on NIFI-1685:
--------------------------------------
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/304#discussion_r57464551
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutSQL.java
---
@@ -144,6 +168,7 @@ public void testInsertWithGeneratedKeys() throws
InitializationException, Proces
@Test
public void testFailInMiddleWithBadStatement() throws
InitializationException, ProcessException, SQLException, IOException {
final TestRunner runner = TestRunners.newTestRunner(PutSQL.class);
+/****
--- End diff --
I'd suggest to simply remove all commented blocks for better visibility,
don't you think ?
> Optimize database Junit tests to reduce execution time.
> -------------------------------------------------------
>
> Key: NIFI-1685
> URL: https://issues.apache.org/jira/browse/NIFI-1685
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Reporter: Toivo Adams
> Assignee: Toivo Adams
> Priority: Minor
> Labels: build, test
>
> Some database Junit tests are slow.
> For example:
> Running org.apache.nifi.processors.standard.TestPutSQL
> Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 116.638 sec
> - in org.apache.nifi.processors.standard.TestPutSQL
> Running org.apache.nifi.processors.standard.util.TestJdbcCommon
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.029 sec -
> in org.apache.nifi.processors.standard.util.TestJdbcCommon
> Running org.apache.nifi.processors.standard.TestExecuteSQL
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.978 sec -
> in org.apache.nifi.processors.standard.TestExecuteSQL
> Running org.apache.nifi.processors.standard.util.TestJdbcHugeStream
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.253 sec -
> in org.apache.nifi.processors.standard.util.TestJdbcHugeStream
> Running org.apache.nifi.processors.standard.QueryDatabaseTableTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.544 sec -
> in org.apache.nifi.processors.standard.QueryDatabaseTableTest
> My dev machine is not the fastest one, but still why waste time.
> One of reasons is creating DBCPService for each test.
> Setting up Connection pooling is expensive operation.
> So DBCPService should be set up only once and reuse in each test.
> Thanks
> Toivo
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
