[ 
https://issues.apache.org/jira/browse/NIFI-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Brown updated NIFI-1630:
-----------------------------
    Attachment: 0002-nifi-1630-PutUDP-processor-created.patch

I've uploaded a new patch ready for review 
(0002-nifi-1630-PutUDP-processor-created.patch) which contains a PutUDP 
processor class that inherits from the AbstractPutEventProcessor class so that 
it reuses the existing UDP network code for sending out datagrams.

There are a couple of design issues for the reviewer to consider:

1) The acquireSender(), relinquishSender() and readContent() helper methods in 
the PutUDP class provide common functionality that is used by both the PutUDP 
and PutSplunk processors (and potentially future subclasses of 
AbstractPutEventProcessor). I therefore recommend that the methods are pushed 
up the inheritance hierarchy into the AbstractPutEventProcessor class so that 
the code can be reused by both processors.

2) There are a couple of non UDP related Processor Properties (timeout and 
charset) that are inherited from AbstractPutEventProcessor and are therefore 
exposed to PutUDP users. They don't cause any issues, they are just redundant 
and may confuse the user. My feeling is that we can probably live with this. An 
alternative solution is to change the inheritance hierarchy so that PutUDP 
doesn't inherit them, but PutSplunk does.

> Create PutUDP Processor
> -----------------------
>
>                 Key: NIFI-1630
>                 URL: https://issues.apache.org/jira/browse/NIFI-1630
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>    Affects Versions: 0.6.0
>            Reporter: Matt Brown
>            Priority: Minor
>              Labels: beginner
>         Attachments: 0001-nifi-1630-PutUDP-processor-created.patch, 
> 0002-nifi-1630-PutUDP-processor-created.patch
>
>
> Create a processor to send each FlowFile as a datagram to a UDP server.
> Processor must provide properties to allow the user to configure the 
> destination host address and port to send to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to