[
https://issues.apache.org/jira/browse/NIFI-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222190#comment-15222190
]
ASF GitHub Bot commented on NIFI-1552:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/318#discussion_r58253202
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/src/main/java/org/apache/nifi/authorization/StandardAuthorizerConfigurationContext.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.authorization;
+
+import java.util.Collections;
+import java.util.Map;
+
+/**
+ *
+ */
+public class StandardAuthorizerConfigurationContext implements
AuthorizerConfigurationContext {
+
+ private final String identifier;
+ private final Map<String, String> properties;
+
+ public StandardAuthorizerConfigurationContext(String identifier,
Map<String, String> properties) {
+ this.identifier = identifier;
+ this.properties = properties;
--- End diff --
This should probably be a copy of the map stored here, no? May also make
sense to do something like:
this.properties = Collections.unmodifiableMap(new HashMap<>(properties));
This way, we don't have to create a new Map object each time that
getProperties() is called.
> Define new Authorizer API
> -------------------------
>
> Key: NIFI-1552
> URL: https://issues.apache.org/jira/browse/NIFI-1552
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core Framework
> Reporter: Matt Gilman
> Assignee: Matt Gilman
> Fix For: 1.0.0
>
>
> - Introduce new Authorizer API
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
