[ 
https://issues.apache.org/jira/browse/MINIFI-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228523#comment-15228523
 ] 

ASF GitHub Bot commented on MINIFI-5:
-------------------------------------

Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/5#discussion_r58732157
  
    --- Diff: minifi-assembly/pom.xml ---
    @@ -96,160 +85,250 @@ limitations under the License.
                 <artifactId>slf4j-api</artifactId>
                 <scope>compile</scope>
             </dependency>
    +
    +        <!-- MiNiFi -->
             <dependency>
    -            <groupId>ch.qos.logback</groupId>
    -            <artifactId>logback-classic</artifactId>
    -            <scope>compile</scope>
    +            <groupId>org.apache.nifi.minifi</groupId>
    +            <artifactId>minifi-resources</artifactId>
    +            <classifier>resources</classifier>
    +            <scope>runtime</scope>
    +            <type>zip</type>
    +            <version>0.0.1-SNAPSHOT</version>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.nifi.minifi</groupId>
    +            <artifactId>minifi-bootstrap</artifactId>
    +            <version>0.0.1-SNAPSHOT</version>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.nifi.minifi</groupId>
    +            <artifactId>minifi-runtime</artifactId>
    +            <version>0.0.1-SNAPSHOT</version>
    +        </dependency>
    +
    +        <!-- MiNiFi NiFi Dependencies -->
    +        <dependency>
    +            <groupId>org.apache.nifi</groupId>
    +            <artifactId>nifi-processor-utils</artifactId>
             </dependency>
    -    </dependencies>
     
    +        <!-- NiFi Assembly Dependencies-->
    +        <dependency>
    +            <groupId>org.apache.nifi</groupId>
    +            <artifactId>nifi-api</artifactId>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.nifi</groupId>
    +            <artifactId>nifi-runtime</artifactId>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.nifi</groupId>
    +            <artifactId>nifi-bootstrap</artifactId>
    --- End diff --
    
    Why is nifi-bootstrap needed? Isn't minifi-bootstrap replacing that? 
    
    Also nifi-bootstrap is explicitly included in the bootstrap lib in 
minifi-assembly's dependencies.xml.


> Create a proof of concept reference implementation
> --------------------------------------------------
>
>                 Key: MINIFI-5
>                 URL: https://issues.apache.org/jira/browse/MINIFI-5
>             Project: Apache NiFi MiNiFi
>          Issue Type: Task
>          Components: Core Framework
>            Reporter: Aldrin Piri
>            Assignee: Aldrin Piri
>             Fix For: 0.0.1
>
>
> As highlighted in a proposed roadmap for 
> https://cwiki.apache.org/confluence/display/NIFI/Proposed+Roadmap it would be 
> advantageous to establish a proof of concept implementation that reuses many 
> of the libraries that drive NiFi to help fill out and provide a test bed for 
> the proposed and new agent functionalities.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to