[
https://issues.apache.org/jira/browse/MINIFI-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232893#comment-15232893
]
ASF GitHub Bot commented on MINIFI-2:
-------------------------------------
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/7#discussion_r59087047
--- Diff:
minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-runtime/src/test/java/org/apache/nifi/minifi/configuration/TestFileChangeNotifier.java
---
@@ -0,0 +1,83 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.minifi.configuration;
+
+import java.nio.file.Paths;
+
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+public class TestFileChangeNotifier {
--- End diff --
Could a unit be added to test the watcher notifying when a config file gets
changed?
> File based implementation
> -------------------------
>
> Key: MINIFI-2
> URL: https://issues.apache.org/jira/browse/MINIFI-2
> Project: Apache NiFi MiNiFi
> Issue Type: Sub-task
> Components: Processing Configuration
> Reporter: Aldrin Piri
> Fix For: 0.0.1
>
> Attachments: ConfigFileExplanation.xml, Properties_Guide.md,
> config.yml
>
>
> A defined schema for processing configuration will need to be defined. XML
> or YAML seem like possible options for achieving this.
> Agent configuration will come from two places, a bootstrap properties file
> and a flow configuration file. The bootstrap will make use of some of the
> original nifi.properties in order to start up the agent. The flow
> configuration file will essentially be a stripped down version of a flow.xml
> (with potentially S2S properties from nifi.properties).
> The format for the bootstrap.properties should likely be similar to
> nifi.properties.
> Further, a way to incorporate this to leverage the libraries from core NiFi
> will aid in achieving a proof of concept implementation more expediently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
