[
https://issues.apache.org/jira/browse/NIFI-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233698#comment-15233698
]
ASF GitHub Bot commented on NIFI-1738:
--------------------------------------
Github user jvwing commented on the pull request:
https://github.com/apache/nifi/pull/334#issuecomment-207841740
@Hejki, this looks like a solid fix to me. One thing I suggest you add is
some unit tests, which I missed when I "fixed" this a couple months ago. If
that sounds like overkill for such a simple change, well... I use to agree :).
I made some [sample tests to verify your
fix](https://github.com/jvwing/nifi/commit/004ca21e50dd4f4c98923dbb9a49528ad8544179),
you are welcome to use them.
> Incorrect logger name for ControllerStatusReportingTask
> -------------------------------------------------------
>
> Key: NIFI-1738
> URL: https://issues.apache.org/jira/browse/NIFI-1738
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 0.5.0, 0.6.0, 0.5.1
> Reporter: Hejki
>
> Name of processorLogger and connectionLogger inside
> ControllerStatusReportingTask are created incorrectly. Current names are
> {{class
> org.apache.nifi.controller.ControllerStatusReportingTask.Connections}} and
> {{class org.apache.nifi.controller.ControllerStatusReportingTask.Processors}}.
> In commit c526656a228389aa972ce7ebc1df037333000516 logger names was repaired
> to {{LoggerFactory.getLogger(ControllerStatusReportingTask.class +
> ".Processors")}}, but correct is
> {{LoggerFactory.getLogger(ControllerStatusReportingTask.class.getName() +
> ".Processors")}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
