[
https://issues.apache.org/jira/browse/MINIFI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243983#comment-15243983
]
ASF GitHub Bot commented on MINIFI-14:
--------------------------------------
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/10#discussion_r59961712
--- Diff:
minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/conf/bootstrap.conf
---
@@ -28,6 +28,16 @@ conf.dir=./conf
# How long to wait after telling MiNiFi to shutdown before explicitly
killing the Process
graceful.shutdown.seconds=20
+# The location for the configuration file
+nifi.minifi.config=./conf/config.yml
+
+# Notifiers to use for the associated agent, comma separated list of class
names
+#nifi.minifi.notifier.components=org.apache.nifi.minifi.bootstrap.configuration.FileChangeNotifier
+
+# File change notifier configuration for path of the file to monitor and
the associated polling period
+#nifi.minifi.notifier.file.config.path=
--- End diff --
Was a bit unsure about how the mechanics of this would work from a general
interface standpoint. What I was thinking was that new configurations could be
pushed in file form by dropping them in a given watch directory and then the
rest would behave as currently specified. If we are watching the file that is
the config itself, this could be a bit messy.
I think watching the file itself could also be fine, but would think that
there would need to be some indicator within the handleChange to a) not ingest
the file as an InputStream and b) not actually write the file out.
Good either way, just want to ensure the various implementations do not
have to cater to that only of the file.
> Add Listener/Notifier Logic to RunMiNiFi
> ----------------------------------------
>
> Key: MINIFI-14
> URL: https://issues.apache.org/jira/browse/MINIFI-14
> Project: Apache NiFi MiNiFi
> Issue Type: Sub-task
> Components: Processing Configuration
> Reporter: Joseph Percivall
> Assignee: Aldrin Piri
> Fix For: 0.0.1
>
>
> The interface for the ConfigurationChangeNotifier and
> ConfigurationChangeListener is done as part of MINIFI-4 but configuration and
> implementation in RunMiNiFi needs to be added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
