[
https://issues.apache.org/jira/browse/NIFI-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265893#comment-15265893
]
ASF GitHub Bot commented on NIFI-1782:
--------------------------------------
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/395#issuecomment-216065515
Hey @scottyaslan this is a great start. I have a couple comments that I
think we need to address before we merge this in and then I have additional
feedback that I think needs to be included in the next Global Menu/Flow Status
PR which will include the remainder of functionality in the mock up in
NIFI-1323.
**For this PR**
- The birdseye view does not render the processor or processGroup preview.
It appears the position is not being accessed correctly.
- Can we move flowfont files into a separate directory under font (next to
the Roboto directories)? Since flowfont.css came with flowfont can we please
co-locate these? We'll also need to identify which images in this bundle were
not produced by us and ensure we're updating license/notice accordingly.
**For the next PR**
- When dragging a component onto the canvas, the source icon leaves the
toolbox when dragged. This icon should remain in the toolbox while a different
icon should follow the cursor onto the canvas. Maybe we should update the
original icon with something that suggests it's draggable while the dragged
icon indicates that a new component is being added. Specifically, I'm thinking
of our New Connection icon which shows a Connection arrow with a '+'.
- The global menu button appears to shift upwards a couple pixels when
clicked. I don't think this button should move. Additionally, the button and
the menu are too disjoint especially while closing. They transition with
different effects and at different rates.
- The logged in user name wraps onto the following line where the Log Out
link would be.
> UI - Refresh NiFi Header to global menu
> ---------------------------------------
>
> Key: NIFI-1782
> URL: https://issues.apache.org/jira/browse/NIFI-1782
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
> Reporter: Scott Aslan
> Assignee: Scott Aslan
> Fix For: 1.0.0
>
>
> AC:
> -Configure ngMaterial theme to match UX definitions per
> https://docs.google.com/document/d/1G1g0zNxdbSJUEH8hm_p1asuf8FE4k-nNFNbpPbK-3po/edit#
> -Update User display
> -Update login/logout display
> -Update Banner display
> -Implement new global menu complete with the foillowing actions
> --Summary
> --Counters
> --Bulletin Board
> --Data Provenance
> --Controller Settings
> --Flow Configuration History
> --Users
> --Templates
> --Help
> --About
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
