[
https://issues.apache.org/jira/browse/NIFI-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278247#comment-15278247
]
ASF GitHub Bot commented on NIFI-1865:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/429
NIFI-1865 Close StreamThrottler when processor stops.
Add close when processor stops.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-1865
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/429.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #429
----
commit ceecc665d3a0f17348436830fd8611e2c4b4596d
Author: Koji Kawamura <[email protected]>
Date: 2016-05-10T14:45:42Z
NIFI-1865 Close StreamThrottler when processor stops.
----
> PostHTTP and ListenHTTP never shutdown LeakyBucketStreamThrottler thread
> ------------------------------------------------------------------------
>
> Key: NIFI-1865
> URL: https://issues.apache.org/jira/browse/NIFI-1865
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 0.4.1
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
> Priority: Minor
>
> LeakyBucketStreamThrottler implements close and inside it it shutdowns
> executorService.
> However, ListenHTTP and PostHTTP doesn't call close, and since those
> processors create new LeakyBucketStreamThrottler instance when it is
> scheduled, it creates new thread without closing the old ones.
> It can be reproduced by repeating stop and start those processors again and
> again. You can confirm the number of threads are increasing by following
> command:
> {code}
> $ watch "ps -M |grep {nifi pid} | wc -l"
> {code}
> or using thread dump
> {code}
> $ tail -f logs/nifi-bootstrap.log |grep LeakyBucketStreamThrottler.java
> from another terminal
> $ kill -3 {nifi pid}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
