[
https://issues.apache.org/jira/browse/NIFI-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279339#comment-15279339
]
ASF GitHub Bot commented on NIFI-1800:
--------------------------------------
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/431#issuecomment-218336255
@markap14 looks like a great start so far!
Just starting to dig in on testing and it appears the listing of Controller
Services for a particular group isn't working. I'm still getting back every
service instead of those defined in the current group (and presumably any
ancestor groups).
Also noticed the displayName isn't being populated for PropertyDescriptor
in components that are not in the root Proces Group. It appears the
StandardControllerServiceProvider (which is invoked to get the displayName)
only considers the root Process Group.
When attempting to run against a 0.x flow.xml.gz where the
ControllerServices are present outside of the rootGroup, I receive the
following error at start up
```
java.lang.IllegalArgumentException: is not a valid version for Flow
serialization. Should be in format <number>.<number>
at
org.apache.nifi.controller.serialization.FlowEncodingVersion.parse(FlowEncodingVersion.java:90)
~[nifi-framework-core-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
at
org.apache.nifi.controller.serialization.FlowEncodingVersion.parse(FlowEncodingVersion.java:71)
~[nifi-framework-core-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
```
> Scope Controller Services by Process Group
> ------------------------------------------
>
> Key: NIFI-1800
> URL: https://issues.apache.org/jira/browse/NIFI-1800
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core Framework, Core UI
> Reporter: Matt Gilman
> Fix For: 1.0.0
>
>
> - Update framework to manage Controller Services by Process Group
> - Update Controller Service persistence to include Process Group
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
