[ 
https://issues.apache.org/jira/browse/NIFI-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280267#comment-15280267
 ] 

ASF GitHub Bot commented on NIFI-1850:
--------------------------------------

Github user scottyaslan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/424#discussion_r62866557
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-transform-json-ui/src/main/webapp/app/components/processor/processor.service.js
 ---
    @@ -0,0 +1,52 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +'use strict';
    +
    +angular.module('standardUI').factory('ProcessorService', function 
ProcessorService($http) {
    --- End diff --
    
    Angular invokes certain functions (like service factories and controllers) 
via the injector. You need to annotate these functions so that the injector 
knows what services to inject into the function. Here you have chosen to do so 
implicitly... If you plan to minify your code and have used implicit 
annotations then your service names will get renamed and your angular app will 
be broken. To allow the minifiers to rename the function parameters and still 
be able to inject the right services, the function needs to be annotated with 
the $inject property. You can read more about it here: 
https://docs.angularjs.org/guide/di 


> JSON-to-JSON Schema Converter Editor
> ------------------------------------
>
>                 Key: NIFI-1850
>                 URL: https://issues.apache.org/jira/browse/NIFI-1850
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Core UI
>            Reporter: Yolanda M. Davis
>            Priority: Minor
>             Fix For: 1.0.0, 0.7.0
>
>
> With NIFI-361 implemented, users can embed a JOLT spec into the TransformJSON 
> processor. However, building the spec is not intuitive enough without the 
> ability to obtain real time feedback on spec syntax and preview output data. 
> Would like to have a specification editor and transform  preview view added 
> to the processor configuration screen to  allow users to immediately see the 
> impact on the output JSON data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to