[ 
https://issues.apache.org/jira/browse/NIFI-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285900#comment-15285900
 ] 

ASF GitHub Bot commented on NIFI-1799:
--------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/442#discussion_r63457225
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
 ---
    @@ -0,0 +1,49 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.controller
    +
    +import org.apache.nifi.connectable.Connectable
    +import org.apache.nifi.connectable.Position
    +import org.apache.nifi.connectable.Positionable
    +import spock.lang.Specification
    +import spock.lang.Unroll
    +
    +class PositionScalerSpec extends Specification {
    +
    +    @Unroll
    +    def "scale #positionableType.getSimpleName()"() {
    +        given:
    --- End diff --
    
    While I think BDD is fairly self-describing, some labels on the 
`given/when/then` blocks will make this more accessible to developers not yet 
exposed to that model. 


> Auto adjust flow layout
> -----------------------
>
>                 Key: NIFI-1799
>                 URL: https://issues.apache.org/jira/browse/NIFI-1799
>             Project: Apache NiFi
>          Issue Type: Sub-task
>          Components: Core Framework, Core UI
>            Reporter: Matt Gilman
>            Assignee: Jeff Storck
>             Fix For: 1.0.0
>
>
> Updates to the canvas to reflect the modernized look and feel and component 
> level authorization will increase the size of each component. We should auto 
> adjust the layouts to the components will not overlap. Below are the current 
> size of each component and the new size:
> {code}
> Processor 310x100 350x130
> Process Group 365x142 380x172
> Remote Process Group  365x140 380x176
> Connection (largest)  188x53 200x55
> Port (root) 160x56 240x75
> Port 160x40 240x50
> Funnel 61x61 48x48
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to