[
https://issues.apache.org/jira/browse/NIFI-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287388#comment-15287388
]
ASF GitHub Bot commented on NIFI-1296:
--------------------------------------
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/366#issuecomment-219830951
Reviewed and tested. LGTM. All tested flows were OK.
Few minor remarks:
- I'd update @CapabilityDescription to help users differentiate Publish/Put
and Consume/Get. As it stands now they will possibly wonder why we have 4
processors to deal with Kafka when listing processors from the UI.
- There is a comment from @joewitt regarding the scope of close() in
AbstractKafkaProcessor. Is it still an open issue?
Otherwise I'm a +1, great job!
> Add capabilities to Kafka NAR to use new Kafka API (0.9)
> --------------------------------------------------------
>
> Key: NIFI-1296
> URL: https://issues.apache.org/jira/browse/NIFI-1296
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 0.4.0
> Reporter: Oleg Zhurakousky
> Assignee: Oleg Zhurakousky
> Fix For: 0.7.0
>
>
> Not sure when can we address this, but the interesting comment in
> https://github.com/apache/nifi/pull/143. The usage of new API may introduce
> issues with running against older Kafka brokers (e.g., 0.8). Need to
> investigate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
