[ 
https://issues.apache.org/jira/browse/NIFI-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289467#comment-15289467
 ] 

ASF GitHub Bot commented on NIFI-1578:
--------------------------------------

Github user adamonduty commented on the pull request:

    https://github.com/apache/nifi/pull/256#issuecomment-220109946
  
    @rstjohn I agree with @alopresto - the webhook is sensitive. Especially 
because the links and content posted on slack are generally internal to teams 
and trusted, inadvertently exposing a webhook URL could leave teams open to 
phishing attacks. And possession of a webhook URL allows one to post to *any* 
public channel or direct message any user.
    
    You have a great point about the validator - it should validate *after* the 
expression language has been applied to allow for use cases like you describe. 
I'm a bit on the fence on assuming a name without a `#` is a channel name 
though. 
    
    We could also expose the `attachments` section. Did you envision a property 
where you could supply a json array as described in <a 
href="https://api.slack.com/docs/attachments";>Slack's documentation</a>? Or did 
you have another approach in mind?


> Create PutSlack processor
> -------------------------
>
>                 Key: NIFI-1578
>                 URL: https://issues.apache.org/jira/browse/NIFI-1578
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Adam Lamar
>            Assignee: Adam Lamar
>             Fix For: 0.7.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to