[
https://issues.apache.org/jira/browse/NIFI-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292168#comment-15292168
]
ASF GitHub Bot commented on NIFI-1884:
--------------------------------------
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/452#discussion_r63956868
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java ---
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.authorization;
+
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+
+/**
+ * Defines a policy for a set of entities to perform a set of actions on a
given resource.
+ */
+public class AccessPolicy {
+
+ private final String identifier;
+
+ private final Resource resource;
+
+ private final Set<String> entities;
+
+ private final Set<RequestAction> actions;
+
+ private AccessPolicy(final AccessPolicyBuilder builder) {
+ this.identifier = builder.identifier;
+ this.resource = builder.resource;
+
+ Set<String> entities = new HashSet<>();
+ if (builder.entities != null) {
+ entities.addAll(builder.entities);
+ }
+ this.entities = Collections.unmodifiableSet(entities);
+
+ Set<RequestAction> actions = new HashSet<>();
+ if (builder.actions != null) {
+ actions.addAll(builder.actions);
+ }
+ this.actions = Collections.unmodifiableSet(actions);
+
+ if (this.identifier == null || this.identifier.trim().isEmpty()) {
+ throw new IllegalArgumentException("Identifier can not be null
or empty");
+ }
+
+ if (this.resource == null) {
+ throw new IllegalArgumentException("Resource can not be null");
+ }
+
+ if (this.entities == null || this.entities.isEmpty()) {
+ throw new IllegalArgumentException("Entities can not be null
or empty");
+ }
+
+ if (this.actions == null || this.actions.isEmpty()) {
+ throw new IllegalArgumentException("Actions can not be null or
empty");
+ }
+ }
+
+ /**
+ * @return the identifier for this policy
+ */
+ public String getIdentifier() {
+ return identifier;
+ }
+
+ /**
+ * @return the resource for this policy
+ */
+ public Resource getResource() {
+ return resource;
+ }
+
+ /**
+ * @return an unmodifiable set of entity ids for this policy
+ */
+ public Set<String> getEntities() {
+ return entities;
+ }
+
+ /**
+ * @return an unmodifiable set of actions for this policy
+ */
+ public Set<RequestAction> getActions() {
+ return actions;
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (obj == null) {
+ return false;
+ }
+ if (getClass() != obj.getClass()) {
+ return false;
+ }
+
+ final AccessPolicy other = (AccessPolicy) obj;
+ return Objects.equals(this.identifier, other.identifier);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hashCode(this.identifier);
+ }
+
+ @Override
+ public String toString() {
+ return String.format("identifier[%s], resource[%s], entityId[%s],
action[%s]",
--- End diff --
I think there is a trailing ", " in the String.format. This applies the
toString() in User, Group, and AccessPolicy.
> Add User & Group API
> --------------------
>
> Key: NIFI-1884
> URL: https://issues.apache.org/jira/browse/NIFI-1884
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core Framework
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Minor
> Fix For: 1.0.0
>
>
> Define the API for managing users, groups, and policies.
> This is to advance the work described in this feature proposal:
> https://cwiki.apache.org/confluence/display/NIFI/Support+Authorizer+API
> The parent JIRA for all authorization work is NIFI-1550.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
