[ 
https://issues.apache.org/jira/browse/NIFI-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301552#comment-15301552
 ] 

Stephane Maarek commented on NIFI-1915:
---------------------------------------

Hi Oleg,

Thanks for the fixes.
I don't necessarily agree with your thought process. 
- I think a power user should have the option not to escape the content of the 
attribute.
- I think a regular user trying to simply convert a csv to a json shouldn't 
have to worry about the content of his csv, and if the input is a$$$2$a1$$a,b , 
he will expect the json { "csv.1":"a$$$2$a1$$a", "csv.2":"b" }

I'm not the one programming it so it's tough, but what about that option?

Thanks,
Stephane

> ReplaceText infinite loops when attribute contains $ sign
> ---------------------------------------------------------
>
>                 Key: NIFI-1915
>                 URL: https://issues.apache.org/jira/browse/NIFI-1915
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 0.6.1
>            Reporter: Stephane Maarek
>            Assignee: Oleg Zhurakousky
>            Priority: Critical
>             Fix For: 1.0.0, 0.7.0
>
>
> I think the biggest issue is that the text inside of an attribute isn't 
> properly escaped when written to a String, which brings conflict when the 
> text contains dollar signs ($)
> That's a big roadblock for me as I can't predict if and when some $ signs may 
> be present in the data
> An easy way to reproduce is to take the csv to json template here:
> https://cwiki.apache.org/confluence/download/attachments/57904847/CsvToJSON.xml?version=1&modificationDate=1442927496000&api=v2
>  
> In the first ReplaceText, replace a,b,c,d by a$a,b,c,d (it simulates data 
> that may or may not contain a $ sign)
> Launch the flow, you'll see the errors / warning / infinite loop



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to