[ 
https://issues.apache.org/jira/browse/NIFI-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302319#comment-15302319
 ] 

ASF GitHub Bot commented on NIFI-1668:
--------------------------------------

Github user olegz commented on the pull request:

    https://github.com/apache/nifi/pull/324#issuecomment-221917899
  
    The issue is not with before, but with _after_, since it effectively acts 
as a _finally_ block. The way it was before if a test failed for whatever 
reason, then the FC.shutdown was not executed, and due to that you had this 
file lock exception.
    
    As for multiple-threading test, it is not black and white, but rather 
allows the system to validate if there are concurrency issues of some type. I 
am also not sure what you mean by scheduling issues as the test controls the 
thread pool. So may be you can clarify.



> Intermittent Test Failure for TestProcessorLifecycle
> ----------------------------------------------------
>
>                 Key: NIFI-1668
>                 URL: https://issues.apache.org/jira/browse/NIFI-1668
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Bryan Bende
>            Assignee: Oleg Zhurakousky
>            Priority: Minor
>             Fix For: 0.7.0
>
>
> A build on Travis produced the errors below, but they are not seen frequently:
> validateProcessorCanBeStoppedWhenOnTriggerThrowsException on 
> validateProcessorCanBeStoppedWhenOnTriggerThrowsException(org.apache.nifi.controller.scheduling.TestProcessorLifecycle)(org.apache.nifi.controller.scheduling.TestProcessorLifecycle)
>   Time elapsed: 0.085 sec  <<< FAILURE!
> java.nio.channels.OverlappingFileLockException: null
>       at sun.nio.ch.SharedFileLockTable.checkList(FileLockTable.java:255)
>       at sun.nio.ch.SharedFileLockTable.add(FileLockTable.java:152)
>       at sun.nio.ch.FileChannelImpl.lock(FileChannelImpl.java:1043)
>       at java.nio.channels.FileChannel.lock(FileChannel.java:1052)
>       at 
> org.wali.MinimalLockingWriteAheadLog.<init>(MinimalLockingWriteAheadLog.java:179)
>       at 
> org.wali.MinimalLockingWriteAheadLog.<init>(MinimalLockingWriteAheadLog.java:108)
>       at 
> org.apache.nifi.controller.state.providers.local.WriteAheadLocalStateProvider.init(WriteAheadLocalStateProvider.java:97)
>       at 
> org.apache.nifi.controller.state.providers.AbstractStateProvider.initialize(AbstractStateProvider.java:34)
>       at 
> org.apache.nifi.controller.state.manager.StandardStateManagerProvider.createStateProvider(StandardStateManagerProvider.java:186)
>       at 
> org.apache.nifi.controller.state.manager.StandardStateManagerProvider.createLocalStateProvider(StandardStateManagerProvider.java:80)
>       at 
> org.apache.nifi.controller.state.manager.StandardStateManagerProvider.create(StandardStateManagerProvider.java:66)
>       at 
> org.apache.nifi.controller.FlowController.<init>(FlowController.java:435)
>       at 
> org.apache.nifi.controller.FlowController.createStandaloneInstance(FlowController.java:366)
>       at 
> org.apache.nifi.controller.scheduling.TestProcessorLifecycle.buildFlowControllerForTest(TestProcessorLifecycle.java:642)
>       at 
> org.apache.nifi.controller.scheduling.TestProcessorLifecycle.validateProcessorCanBeStoppedWhenOnTriggerThrowsException(TestProcessorLifecycle.java:477)
> Results :
> Failed tests: 
>   
> TestProcessorLifecycle.validateDisableOperation:117->buildFlowControllerForTest:642
>  » OverlappingFileLock
>   
> TestProcessorLifecycle.validateLifecycleOperationOrderWithConcurrentCallsToStartStop:254->buildFlowControllerForTest:642
>  » OverlappingFileLock
>   
> TestProcessorLifecycle.validateProcessScheduledAfterAdministrativeDelayDueToTheOnScheduledException:347->buildFlowControllerForTest:642
>  » OverlappingFileLock
>   
> TestProcessorLifecycle.validateProcessorCanBeStoppedWhenOnScheduledBlocksIndefinitelyInterruptable:413->buildFlowControllerForTest:642
>  » OverlappingFileLock
>   
> TestProcessorLifecycle.validateProcessorCanBeStoppedWhenOnScheduledBlocksIndefinitelyUninterruptable:443->buildFlowControllerForTest:642
>  » OverlappingFileLock
>   
> TestProcessorLifecycle.validateProcessorCanBeStoppedWhenOnScheduledConstantlyFails:380->buildFlowControllerForTest:642
>  » OverlappingFileLock
>   
> TestProcessorLifecycle.validateProcessorCanBeStoppedWhenOnTriggerThrowsException:477->buildFlowControllerForTest:642
>  » OverlappingFileLock
>   
> TestProcessorLifecycle.validateProcessorUnscheduledAndStoppedWhenStopIsCalledBeforeProcessorFullyStarted:311->buildFlowControllerForTest:642
>  » OverlappingFileLock
>   
> TestProcessorLifecycle.validateStartSucceedsOnProcessorWithEnabledService:554->buildFlowControllerForTest:642
>  » OverlappingFileLock
>   
> TestProcessorLifecycle.validateStopCallsAreMeaninglessIfProcessorNotStarted:187->buildFlowControllerForTest:642
>  » OverlappingFileLock
>   TestProcessorLifecycle.validateSuccessfullAndOrderlyShutdown:239 
> expected:<3> but was:<2>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to