[ 
https://issues.apache.org/jira/browse/NIFI-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310678#comment-15310678
 ] 

ASF GitHub Bot commented on NIFI-1929:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/486

    NIFI-1929: Improvements for PutHDFS attribute handling

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-1929

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/486.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #486
    
----
commit 856c7d157643cbc77313f0a56987d8cf4a0d843b
Author: Matt Burgess <[email protected]>
Date:   2016-06-01T17:16:10Z

    NIFI-1929: Improvements for PutHDFS attribute handling

----


> Improvements for PutHDFS attribute handling
> -------------------------------------------
>
>                 Key: NIFI-1929
>                 URL: https://issues.apache.org/jira/browse/NIFI-1929
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>
> The following is a list of improvements/fixes to attribute handling in 
> PutHDFS for consideration:
> 1) The documentation says that PutHDFS writes the "filename" attribute with 
> the description: "The name of the file written to HDFS comes from the value 
> of this attribute." PutHDFS should add a @ReadsAttribute annotation with the 
> above description.
> 2) The @WritesAttribute description above should read something like: The 
> name of the file written to HDFS is stored in this attribute." Also it 
> doesn't appear by the code that this is accurate; the filename could've 
> changed depending on the compression option, but it appears the original 
> filename attribute value is retained
> 3) PutHDFS should write an attribute (such as absolute.path like GetFile) 
> that contains the value of the Directory property after any Expression 
> Language has been evaluated. This would be documented via @WritesAttribute.
> #2 and #3 are being done for the Transit URI in the reported provenance 
> event(s), this should be extended to the flow file attributes as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to