[ 
https://issues.apache.org/jira/browse/NIFI-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333871#comment-15333871
 ] 

Adam Taft edited comment on NIFI-1620 at 6/16/16 2:18 PM:
----------------------------------------------------------

This is a very good point Joe.  Pierre I agree with your assessment as well, 
the backwards compatibility point is legitimate.

And additionally to these points, there is good parallelism between the 
proposed "Send Message Body" and the existing "Attributes to Send" (via http 
headers) configuration properties.  That is, with the "attributes to send" 
property, you can control the headers that are sent. With the proposed "send 
message body" property, you can control if the message body is sent.  So maybe 
there is good synergy there between these properties.

OK, so let's merge this in.  I think Pierre might be fixing up the whitespace 
issue I mentioned in the PR and possibly the empty RequestBody.  But overall I 
think this change makes sense and should be included.

Joe - can you please merge this in, when Pierre is finished with it?  I don't 
have a good environment right now to do so.


was (Author: taftster):
This is a very good point Joe.  Pierre I agree with your assessment as well, 
the backwards compatibility point is legitimate.

And additionally to these points, there is good parallelism between the 
proposed "Send Message Body" and the existing "Attributes to Send" (via http 
headers) configuration properties.  That is, with the "attributes to send" 
property, you can control the headers that are sent. With the proposed "send 
message body" property, you can control if the message body is sent.  So maybe 
there is good synergy there between these properties.

OK, so let's merge this in.  I think Pierre might be fixing up the whitespace 
issue I mentioned in the PR and possibly the empty RequestBody.  But overall I 
think this additionally property makes sense and should be included.

Joe - can you please merge this in, when Pierre is finished with it?  I don't 
have a good environment right now to do so.

> Allow empty Content-Type in InvokeHTTP processor
> ------------------------------------------------
>
>                 Key: NIFI-1620
>                 URL: https://issues.apache.org/jira/browse/NIFI-1620
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 0.5.1
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>             Fix For: 1.0.0, 0.7.0
>
>
> External API could expect a POST request without a Content-Type property or 
> at least with this property empty:
> *Error example:*
> {quote}
> You provided a non-empty HTTP "Content-Type" header ("application/json").  
> This API function requires that the header be missing or empty.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to