[
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334819#comment-15334819
]
ASF GitHub Bot commented on NIFI-1838:
--------------------------------------
Github user PuspenduBanerjee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/534#discussion_r67434506
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
---
@@ -92,11 +92,10 @@
logger.error(message, t);
}
}
- } else {
- // Return defaults for now
- relationships.add(REL_SUCCESS);
- relationships.add(REL_FAILURE);
}
+ // Add defaults
+ relationships.add(REL_SUCCESS);
+ relationships.add(REL_FAILURE);
--- End diff --
@pvillard31 Please check the use of session.transfer(flowFile,
InvokeScriptedProcessor.REL_SUCCESS) in test_reader.groovy#onTrigger. All
groovy test cases uses REL_SUCCESS or REL_FAILURE . It is not a problem in
pre-NIFI-1152 and that's why I had to raise NIFI-1838.
> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> ----------------------------------------------------------------------
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.0.0, 0.6.1
> Reporter: Puspendu Banerjee
> Labels: patch
> Fix For: 1.0.0
>
> Attachments:
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they
> don't define Relationships properly
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
