[ 
https://issues.apache.org/jira/browse/NIFI-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339763#comment-15339763
 ] 

ASF GitHub Bot commented on NIFI-1895:
--------------------------------------

Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/542#discussion_r67714535
  
    --- Diff: 
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java
 ---
    @@ -89,6 +89,25 @@
                 .defaultValue(COMPLEX_FIELD_TEXT.getValue())
                 .build();
     
    +    protected static final String STRING_ENCODING_VALUE = "String";
    +    protected static final String BYTES_ENCODING_VALUE = "Bytes";
    +
    +    protected static final AllowableValue FIELD_ENCODING_STRING = new 
AllowableValue(STRING_ENCODING_VALUE, STRING_ENCODING_VALUE,
    +            "Stores the value of each field as a UTF-8 String.");
    --- End diff --
    
    Secondly, will users configuring this processor know what a "String" is 
(aka. is it a concept that is used regularly when configuring HBase)?


> PutHBaseJSON processor treats all Values as Strings
> ---------------------------------------------------
>
>                 Key: NIFI-1895
>                 URL: https://issues.apache.org/jira/browse/NIFI-1895
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 0.6.1
>            Reporter: Ryan Templeton
>
> line 184 of PutHBaseJSON.java treats all JsonNode values as strings by 
> calling the .asText() method. We are working with using this processor to 
> load IoT time series data and this causes issues in HBase with 
> timestamps/numerics not getting sorted correctly.
> The operator should inspect the node value to determine type and convert as 
> such.
> Numeric integral - Long (assumes widest type)
> Numeric not integral - Double (assumes widest type)
> Logical - Boolean
> everything else (including current Complex Type logic) - String



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to