[
https://issues.apache.org/jira/browse/NIFI-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340006#comment-15340006
]
ASF GitHub Bot commented on NIFI-1834:
--------------------------------------
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67732631
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutTCP.java
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.processors.standard.util.TestPutTCPCommon;
+
+public class TestPutTCP extends TestPutTCPCommon {
+
+ public TestPutTCP() {
+ super();
+ ssl = false;
+ }
+
+ @Override
+ public void configureProperties(String host, int port, String
outgoingMessageDelimiter, boolean connectionPerFlowFile, boolean expectValid) {
+ runner.setProperty(PutTCP.HOSTNAME, host);
+ runner.setProperty(PutTCP.PORT, Integer.toString(port));
+ if (outgoingMessageDelimiter != null) {
+ runner.setProperty(PutTCP.OUTGOING_MESSAGE_DELIMITER,
outgoingMessageDelimiter);
+ }
+ if (connectionPerFlowFile) {
+ runner.setProperty(PutTCP.CONNECTION_PER_FLOWFILE, "true");
+ } else {
+ runner.setProperty(PutTCP.CONNECTION_PER_FLOWFILE, "false");
+ }
--- End diff --
This is more of a style but it appears it would be a bit more concise if
the whole IF/ELSE would look like this
```java
runner.setProperty(PutTCP.CONNECTION_PER_FLOWFILE, connectionPerFlowFile ?
"true" : "false");
```
> Create PutTCP Processor
> -----------------------
>
> Key: NIFI-1834
> URL: https://issues.apache.org/jira/browse/NIFI-1834
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
> Reporter: Matt Brown
> Priority: Minor
> Fix For: 1.0.0, 0.7.0
>
> Attachments: 0001-PutTCP-Processor-created.patch
>
>
> Create a PutTCP Processor to send FlowFile content over a TCP connection to a
> TCP server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
