[ 
https://issues.apache.org/jira/browse/NIFI-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340100#comment-15340100
 ] 

ASF GitHub Bot commented on NIFI-2032:
--------------------------------------

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/541#discussion_r67739760
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java
 ---
    @@ -70,7 +67,7 @@
     
         private final ProcessScheduler processScheduler;
         private static final Set<Method> validDisabledMethods;
    -    private final BulletinRepository bulletinRepo;
    +    // private final BulletinRepository bulletinRepo;
    --- End diff --
    
    I would have to defer to @markap14 but it appears it was being used. See 
below.


> Processors could be started before the Controller Services that they depend on
> ------------------------------------------------------------------------------
>
>                 Key: NIFI-2032
>                 URL: https://issues.apache.org/jira/browse/NIFI-2032
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Oleg Zhurakousky
>            Priority: Critical
>             Fix For: 1.0.0, 0.7.0
>
>
> in the StandardControllerServiceProvider, we enable a Collection of 
> Controller Services but do so in the background with a limited number of 
> threads. We need to ensure that all Controller Services have at least become 
> ENABLING before returning from this method. Otherwise, Processors that depend 
> on them could attempt to start. If this happens, the Processor will be 
> invalid because it references a Disabled Controller Service. As a result, the 
> Processor will not start. In a clustered environment, we will end up with 
> inconsistent run states across the nodes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to